Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(parser): Fixed MarshalJSON Error on YAML Extend #3414 #3423

Merged
merged 2 commits into from
May 25, 2021
Merged

fix(parser): Fixed MarshalJSON Error on YAML Extend #3414 #3423

merged 2 commits into from
May 25, 2021

Conversation

joaoReigota1
Copy link
Collaborator

Signed-off-by: João Reigota [email protected]

Closes #3414

Since nested maps were being converted to type map[interface{}]interface{} json marshal was reporting an error

Proposed Changes

  • Added converter to convert map[interface{}]interface{} values to map[string]interface{}

I submit this contribution under the Apache-2.0 license.

@joaoReigota1 joaoReigota1 added bug Something isn't working go Pull requests that update Go code labels May 24, 2021
@joaoReigota1 joaoReigota1 self-assigned this May 24, 2021
@kicsbot
Copy link
Contributor

kicsbot commented May 24, 2021

Scan submitted to Checkmarx

@kicsbot
Copy link
Contributor

kicsbot commented May 24, 2021

Logo
Checkmarx SAST - Scan Summary & Details

Cx-SAST Summary

Total of 0 vulnerabilities
High 0 High
Medium 0 Medium
Low 0 Low
Info 0 Info

Violation Summary

No policy violation found

@rogeriopeixotocx rogeriopeixotocx added this to the Core Engineering milestone May 24, 2021
rogeriopeixotocx
rogeriopeixotocx approved these changes May 25, 2021
View reviewed changes
Copy link
Contributor

@rogeriopeixotocx rogeriopeixotocx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rogeriopeixotocx rogeriopeixotocx merged commit 6add88e into master May 25, 2021
@rogeriopeixotocx rogeriopeixotocx deleted the fix/marshalJSON_error_YAML_extend branch May 25, 2021 21:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rogeriopeixotocx rogeriopeixotocx rogeriopeixotocx approved these changes

@rafaela-soares rafaela-soares Awaiting requested review from rafaela-soares

@felipe-avelar felipe-avelar Awaiting requested review from felipe-avelar

Assignees

@joaoReigota1 joaoReigota1

Labels
bug Something isn't working go Pull requests that update Go code
Projects
None yet
Milestone
Core Engineering
Development

Successfully merging this pull request may close these issues.

MarshalJSON Error on YAML Extend
3 participants
@joaoReigota1 @kicsbot @rogeriopeixotocx